Re: What's cooking in git.git (Jan 2016, #02; Mon, 11)

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 25, 2016, 22:03 UTC
Message-ID: <xmqqa8ntfha6.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CACsJy8D2x1DtzNGB+zjoLxNwZoG2cVkkU9=ziHtRiV6rfBVc7Q@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 25 quoted lines

> On Tue, Jan 12, 2016 at 6:45 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> * jk/graph-format-padding (2015-09-14) 1 commit
>>  - pretty: pass graph width to pretty formatting for use in '%>|(N)'
>>
>>  Redefine the way '%>|(N)' padding and the "--graph" option
>>  interacts.  It has been that the available columns to display the
>>  log message was measured from the edge of the area the graph ended,
>>  but with this it becomes the beginning of the entire output.
>>
>>  I have a suspicion that 50% of the users would appreciate this
>>  change, and the remainder see this break their expectation.  If
>>  that is the case, we might need to introduce a similar but
>>  different alignment operator so that this new behaviour is
>>  available to those who want to use it, without negatively affecting
>>  existing uses.
>>
>>  No comments after waiting for a long time.
>>  Will discard.
>>  ($gmane/278326)
>
> I carried this in my tree and didn't realize it's dropped from 'pu'.
> There's actually a comment last month [1]. By your last comment, does
> it mean I should check if "it" breaks anything to resurrect this one?
>
> [1] http://thread.gmane.org/gmane.comp.version-control.git/277710/focus=282886

Ahh, yes, I remember that your response was that the patch is good and we do not need a new separate way (as there already is one) to specify the other behaviour. So if that is truly the case (I didn't check it), we would certainly want to resurrect it, as there wouldn't be any downside to it.

Thanks.