git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jan 2016, #02; Mon, 11)

From
Jeff King <peff@peff.net>
Date
Jan 14, 2016, 10:21 UTC
Message-ID
<20160114102134.GD30772@sigill.intra.peff.net>
In-Reply-To
<xmqqlh7tkpcy.fsf@gitster.mtv.corp.google.com>
On Wed, Jan 13, 2016 at 03:54:05PM -0800, Junio C Hamano wrote:
Show 15 quoted lines
> And after doing the obvious wholesale replacement on callers that
> hardcode either '\n' or '\0' with this:
> 
> #!/bin/sh
> perl -i -p -e '
> 	s/strbuf_getline\((.*?), '\''\\n'\''\)/strbuf_getline_lf($1)/g;
> 	s/strbuf_getline\((.*?), '\''\\0'\''\)/strbuf_getline_nul($1)/g;
> ' "$@"
> 
> the only direct callers of strbuf_getline() that remain in the tree
> are check-attr, check-ignore, checkout-index and mktree.
> 
> And the conversion of mktree would look like this.  I might further
> tweak it to rename and flip the polarity of lf_lines to nul_lines,
> but I do not think that matters very much.

Heh. I read your series first, and independently came up with the same polarity-flipping thought. I agree it doesn't matter much, but maybe we can count that as two votes. :)

-Peff
Previous: Junio C HamanoNext: David A. Greene
Message 12 of 19 in “What's cooking in git.git (Jan 2016, #02; Mon, 11)”
  1. Junio C HamanoJan 11, 2016
  2. Mike HommeyJan 12, 2016
  3. Junio C HamanoJan 12, 2016
  4. Edmundo Carmona AntoranzJan 12, 2016
  5. Johannes SchindelinJan 12, 2016
  6. Junio C HamanoJan 12, 2016
  7. Jeff KingJan 12, 2016
  8. Junio C HamanoJan 13, 2016
  9. Jeff KingJan 13, 2016
  10. Junio C HamanoJan 13, 2016
  11. Junio C HamanoJan 13, 2016
  12. Jeff KingJan 14, 2016
  13. David A. GreeneJan 13, 2016
  14. Michael J GruberJan 18, 2016
  15. Jeff KingJan 18, 2016
  16. Eric WongJan 18, 2016
  17. Michael J GruberJan 19, 2016
  18. Duy NguyenJan 25, 2016
  19. Junio C HamanoJan 25, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.