Re: [PATCH 1/3] submodule update: make use of the existing fetch_in_submodule function

From: Junio C Hamano <gitster@pobox.com>
Date: May 25, 2016, 22:41 UTC
Message-ID: <xmqqa8jdzroz.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160525220006.27138-2-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 18 quoted lines

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  git-submodule.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 5a4dec0..7698102 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -640,7 +640,7 @@ cmd_update()
>  			if test -z "$nofetch"
>  			then
>  				# Fetch remote before determining tracking $sha1
> -				(sanitize_submodule_env; cd "$sm_path" && git-fetch) ||
> +				fetch_in_submodule "$sm_path" ||
>  				die "$(eval_gettext "Unable to fetch in submodule path '\$sm_path'")"
>  			fi
>  			remote_name=$(sanitize_submodule_env; cd "$sm_path" && get_default_remote)

Makes sense. The main topic does not depend on this change, I hope, as I think it is OK to queue this separately and have it graduate before 2.9-rc1.