git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] Submodules: have a depth field in the .gitmodules file

From
Stefan Beller <sbeller@google.com>
Date
May 25, 2016, 22:44 UTC
Message-ID
<CAGZ79kZOmqcB_q48upzpEnF6Lb9wqt2NMOBhTH7EvE5LfAqabg@mail.gmail.com>
In-Reply-To
<xmqqeg8pzrsu.fsf@gitster.mtv.corp.google.com>
On Wed, May 25, 2016 at 3:38 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>> Sometimes the history of a submodule is not considered important by
>> the projects upstream. To make it easier for downstream users, allow
>> a field 'submodule.<name>.depth' in .gitmodules, which can be used
>> to indicate the recommended depth.
>
> Hmph.  I can understand and certainly agree with the first sentence,
> but I am not sure if "depth", if it is anything other than "1" or
> "infinity", is a reasonable value.
>
> I'd understand if a project wants to say something like "at this
> moment, history before v2.0 tag does not matter", though.

I fell for the trap, like all depth related problems fall into. I came up with the easiest solution to be implemented into Git, not what the user actually wants.

Background for this change is trying to get a similar thing like the "clone-depth" field from repo manifests implemented into Git. And looking at e.g. [1], this is either non existent (infinity) or 1. So maybe instead of giving a depth recommendation in the .gitmodules, we only fill in a boolean config "[non]shallow" which defaults to non shallow in case of not giving the field.

Thanks, Stefan

[1] https://android.googlesource.com/platform/manifest/+/master/default.xml
Previous: Junio C HamanoNext: medoo
Message 8 of 9 in “Submodules: have a depth field in the .gitmodules file”
  1. 0/3 Submodules: have a depth field in the .gitmodules fileStefan Beller, May 25, 2016
  2. 1/3 submodule update: make use of the existing fetch_in_submodule functionStefan Beller, May 25, 2016
  3. Junio C HamanoMay 25, 2016
  4. Stefan BellerMay 25, 2016
  5. 2/3 submodule-config: keep `depth` aroundStefan Beller, May 25, 2016
  6. 3/3 submodule update: learn `--recommended-depth` optionStefan Beller, May 25, 2016
  7. Junio C HamanoMay 25, 2016
  8. Stefan BellerMay 25, 2016
  9. medooAug 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.