Re: [PATCH 2/3] diff_populate_filespec: NUL-terminate buffers

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 8, 2016, 16:57 UTC
Message-ID: <xmqqa8fijpmg.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160908082246.saf7vlw2xgjo7jvg@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> Between the two options for regexec_buf(), I think you have convinced me
> that REG_STARTEND is better than just using compat/regex everywhere. I
> do think the fallback for platforms like musl should be "use
> compat/regex" and not doing an expensive copy (which in most cases is
> not even necessary).

I agree with you that it would be the best approach to build regexec_buf() that unconditionally uses REG_STARTEND and tell people without REG_STARTEND to use compat/regex instead of their platform regex library.

The description in Makefile may want to be rephrased to clarify.

-# Define NO_REGEX if you have no or inferior regex support in your C library. +# Define NO_REGEX if your C library lacks regex support with REG_STARTEND +# feature.

The word "inferior" is not giving any useful information there.