Re: [PATCH v4 2/3] regex: add regexec_buf() that can work on a non NUL-terminated string
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 22, 2016, 18:38 UTC
- Message-ID
- <alpine.DEB.2.20.1609222032330.129229@virtualbox>
- In-Reply-To
- <xmqqtwd96p0b.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 21 Sep 2016, Junio C Hamano wrote:
Show 19 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes: > > > ... > > Happily, there is an extension to regexec() introduced by the NetBSD > > project and present in all major regex implementation including > > Linux', MacOSX' and the one Git includes in compat/regex/: by using > > the (non-POSIX) REG_STARTEND flag, it is possible to tell the > > regexec() function that it should only look at the offsets between > > pmatch[0].rm_so and pmatch[0].rm_eo. > > > > That is exactly what we need. > > Wonderful. > > > Since support for REG_STARTEND is so widespread by now, let's just > > introduce a helper function that uses it, and fall back to allocating > > and constructing a NUL-terminated when REG_STARTEND is not available. > > I'd somehow reword the last paragraph here, though ;-)
Oh drats. I thought I had prepared the fixed commit messages already :-(
What you have in `pu` as of today looks good.
Ciao, Dscho