Re: [PATCH v2 0/3] Fix a segfault caused by regexec() being called on mmap()ed data
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 8, 2016, 07:33 UTC
- Message-ID
- <alpine.DEB.2.20.1609080931250.129229@virtualbox>
- In-Reply-To
- <cover.1473319844.git.johannes.schindelin@gmx.de>
Hi,
On Thu, 8 Sep 2016, Johannes Schindelin wrote:
> We solve this by introducing a helper, regexec_buf(), that takes a > pointer and a length instead of a NUL-terminated string.
BTW I should have clarified why I decided on another name than regexecn() (I had considered this even before reading Peff's proposed patch): the <n> in string functions suggest a limiting of NUL-terminated strings. In other words, if n = 100 and the provided pointer points to a NUL-terminated string of length 3, the *n function will treat it as a string of length 3.
That is not what regexec_buf() does: it ignores the NUL. Hence the different name.
Ciao, Dscho