git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (May 2017, #01; Mon, 1)

From
Junio C Hamano <gitster@pobox.com>
Date
May 1, 2017, 23:21 UTC
Message-ID
<xmqqa86wgo33.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CACBZZX4ty91vh=ykMtpF0pV8Ru3BKWBXyQYsFRdPkKkxMd8pzw@mail.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 26 quoted lines
>> * ab/grep-pcre-v2 (2017-04-25) 20 commits
>>  - SQUASH???
>>  - Makefile & configure: make PCRE v2 the default PCRE implementation
>>  - grep: remove support for concurrent use of both PCRE v1 & v2
>>  - grep: add support for PCRE v2
>>  - grep: add support for the PCRE v1 JIT API
>>  - perf: add a performance comparison test of grep -E and -P
>>  - grep: change the internal PCRE code & header names to be PCRE1
>>  - grep: change the internal PCRE macro names to be PCRE1
>>  - test-lib: rename the LIBPCRE prerequisite to PCRE
>>  - grep: make grep.patternType=[pcre|pcre1] a synonym for "perl"
>>  - grep & rev-list doc: stop promising libpcre for --perl-regexp
>>  - log: add -P as a synonym for --perl-regexp
>>  - log: add exhaustive tests for pattern style options & config
>>  - grep: add a test for backreferences in PCRE patterns
>>  - Makefile & configure: reword outdated comment about PCRE
>>  - grep: remove redundant `regflags &= ~REG_EXTENDED` assignments
>>  - grep: remove redundant regflags assignment under PCRE
>>  - grep: submodule-related case statements should die if new fields are added
>>  - grep: add tests for grep pattern types being passed to submodules
>>  - grep: amend submodule recursion test in preparation for rx engine testing
>>
>>  PCRE2, which has an API different from and incompatible with PCRE,
>>  can now be chosen to support "grep -P -e '<pattern>'" and friends.
>
> That squash looks good to me.
Thanks.

That is not a particulary helpful comment, by the way. I can help topics by contributors by queuing emergency fix at the tip to make ones that do not build correctly buildable and testable (which is what the "SQUASH???" commits are about), but I'd rather not see me forced to find among 19 commits which one is broken and needs the hotfix squashed in myself.

Show 20 quoted lines
>> * ab/grep-threading-cleanup (2017-04-16) 8 commits
>>  - grep: given --threads with NO_PTHREADS=YesPlease, warn
>>  - pack-objects: fix buggy warning about threads under NO_PTHREADS=YesPlease
>>  - pack-object & index-pack: add test for --threads warning under NO_PTHREADS
>>  - tests: add a PTHREADS prerequisite
>>  - grep: skip pthreads overhead when using one thread
>>  - grep: don't redundantly compile throwaway patterns under threading
>>  - grep: add tests for --threads=N and grep.threads
>>  - grep: assert that threading is enabled when calling grep_{lock,unlock}
>>
>>  Code cleanup.
>>
>>  Needs review.
>
> Between these two series there's 27 patches, and I understand it's a
> bit of a PITA to review/get comments on it.
>
> Anything I should be doing differently here other than just waiting
> for 2.13 to come out so they can be cooked further & merged down to
> next & then master if there's no objections?

There are topics that need fresh eyes to be reviewed by other contributors, so perhaps you can help unblock them by reviewing, while they pick lints from yours?

Previous: Jeff KingNext: Ævar Arnfjörð Bjarmason
Message 6 of 36 in “What's cooking in git.git (May 2017, #01; Mon, 1)”
  1. Junio C HamanoMay 1, 2017
  2. Ævar Arnfjörð BjarmasonMay 1, 2017
  3. Brandon WilliamsMay 1, 2017
  4. Ævar Arnfjörð BjarmasonMay 1, 2017
  5. Jeff KingMay 1, 2017
  6. Junio C HamanoMay 1, 2017
  7. Ævar Arnfjörð BjarmasonMay 2, 2017
  8. Junio C HamanoMay 2, 2017
  9. Ævar Arnfjörð BjarmasonMay 2, 2017
  10. Johannes SchindelinMay 2, 2017
  11. PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)Johannes Schindelin, May 2, 2017
  12. Ævar Arnfjörð BjarmasonMay 2, 2017
  13. Johannes SchindelinMay 2, 2017
  14. Ævar Arnfjörð BjarmasonMay 2, 2017
  15. Kevin DaudtMay 2, 2017
  16. Ævar Arnfjörð BjarmasonMay 2, 2017
  17. Johannes SchindelinMay 3, 2017
  18. Duy NguyenMay 3, 2017
  19. Ævar Arnfjörð BjarmasonMay 3, 2017
  20. Johannes SchindelinMay 4, 2017
  21. Ævar Arnfjörð BjarmasonMay 4, 2017
  22. Johannes SchindelinMay 4, 2017
  23. Ævar Arnfjörð BjarmasonMay 4, 2017
  24. Ævar Arnfjörð BjarmasonMay 8, 2017
  25. Junio C HamanoMay 8, 2017
  26. brian m. carlsonMay 8, 2017
  27. Ævar Arnfjörð BjarmasonMay 9, 2017
  28. brian m. carlsonMay 9, 2017
  29. Johannes SchindelinMay 9, 2017
  30. Ævar Arnfjörð BjarmasonMay 9, 2017
  31. Ævar Arnfjörð BjarmasonMay 9, 2017
  32. demerphqMay 9, 2017
  33. Ævar Arnfjörð BjarmasonMay 9, 2017
  34. Brandon WilliamsMay 2, 2017
  35. Ævar Arnfjörð BjarmasonMay 2, 2017
  36. Ramsay JonesMay 5, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.