Re: PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- May 4, 2017, 11:53 UTC
- Message-ID
- <CACBZZX7DKOvcCRCHgkxiCOVx4XH=B1C+0=Q_ykjm3Odk-aWEWw@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.2.21.1.1705041328190.4905@virtualbox>
On Thu, May 4, 2017 at 1:32 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 22 quoted lines
> Hi Ævar, > > On Thu, 4 May 2017, Ævar Arnfjörð Bjarmason wrote: > >> So I think if your criteria for working on integrating v2 is users >> noticing it elsewhere and asking you for it you'll likely never switch >> to it. > > Speaking for myself, my biggest problem with your patch series is to find > the time to work on packaging PCRE v2 as an MSYS2 package. > > If you force me to make that time *now*, by forcing the switch to v2 in > `pu`, you will disimprove my mood. That's all. > > If, however, you are gently with people like me, offering this as an > opt-in, so that I can play with it when I find some time to build PCRE v2 > in MSYS2's context, I will be pretty happy, and of course will ship Git > for Windows with the faster PCRE support as soon as I am satisfied that it > works correctly. > > That should make you happy, too, as you will get quite a bit of testers > that way. Gently.
Sure, all makes sense. As noted I'll keep it from being the default for now.
The only reason I even replied & kept this thread going now was because I noticed "make" not enabling it, REG_STARTEND making \0 searches work in practice (even if not specified by the NetBSD extension) etc.
All stuff I would surely forget by the time we have the discussion again down the road, so I wanted to get that E-Mail out now for future reference.