git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (May 2017, #01; Mon, 1)

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
May 5, 2017, 01:12 UTC
Message-ID
<4fe7bb75-2d4d-37b2-910c-e63cfdfa5282@ramsayjones.plus.com>
In-Reply-To
<xmqqefw9gmvq.fsf@gitster.mtv.corp.google.com>
On 01/05/17 06:35, Junio C Hamano wrote:
Show 26 quoted lines
> 
> * nd/fopen-errors (2017-04-23) 17 commits
>  - warn_failure_to_open_read_optional_path(): a new helper
>  - t1308: add a test case on open a config directory
>  - config.c: handle error on failing to fopen()
>  - xdiff-interface.c: report errno on failure to stat() or fopen()
>  - wt-status.c: report error on failure to fopen()
>  - server-info: report error on failure to fopen()
>  - sequencer.c: report error on failure to fopen()
>  - rerere.c: report correct errno
>  - rerere.c: report error on failure to fopen()
>  - remote.c: report error on failure to fopen()
>  - commit.c: report error on failure to fopen() the graft file
>  - log: report errno on failure to fopen() a file
>  - clone: use xfopen() instead of fopen()
>  - blame: report error on open if graft_file is a directory
>  - bisect: report on fopen() error
>  - config.mak.uname: set FREAD_READS_DIRECTORIES for Linux and FreeBSD
>  - git_fopen: fix a sparse 'not declared' warning
> 
>  We often try to open a file for reading whose existence is
>  optional, and silently ignore errors from open/fopen; report such
>  errors if they are not due to missing files.
> 
>  Expecting a reroll that would be much simplified thanks to a higher
>  level helper.

Since this "What's cooking", this has been re-rolled, but the "git_fopen: fix a sparse 'not declared' warning" patch has been dropped, so I'm seeing the sparse warning again.

Also, this series removes every external caller of the 'warn_on_inaccessible()' function, so this could be marked static in wrapper.c. (I would move the definition of that function above/before warn_on_fopen_errors(), in order not to require a forward declaration).

ATB, Ramsay Jones

Previous: Ævar Arnfjörð Bjarmason
Message 36 of 36 in “What's cooking in git.git (May 2017, #01; Mon, 1)”
  1. Junio C HamanoMay 1, 2017
  2. Ævar Arnfjörð BjarmasonMay 1, 2017
  3. Brandon WilliamsMay 1, 2017
  4. Ævar Arnfjörð BjarmasonMay 1, 2017
  5. Jeff KingMay 1, 2017
  6. Junio C HamanoMay 1, 2017
  7. Ævar Arnfjörð BjarmasonMay 2, 2017
  8. Junio C HamanoMay 2, 2017
  9. Ævar Arnfjörð BjarmasonMay 2, 2017
  10. Johannes SchindelinMay 2, 2017
  11. PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)Johannes Schindelin, May 2, 2017
  12. Ævar Arnfjörð BjarmasonMay 2, 2017
  13. Johannes SchindelinMay 2, 2017
  14. Ævar Arnfjörð BjarmasonMay 2, 2017
  15. Kevin DaudtMay 2, 2017
  16. Ævar Arnfjörð BjarmasonMay 2, 2017
  17. Johannes SchindelinMay 3, 2017
  18. Duy NguyenMay 3, 2017
  19. Ævar Arnfjörð BjarmasonMay 3, 2017
  20. Johannes SchindelinMay 4, 2017
  21. Ævar Arnfjörð BjarmasonMay 4, 2017
  22. Johannes SchindelinMay 4, 2017
  23. Ævar Arnfjörð BjarmasonMay 4, 2017
  24. Ævar Arnfjörð BjarmasonMay 8, 2017
  25. Junio C HamanoMay 8, 2017
  26. brian m. carlsonMay 8, 2017
  27. Ævar Arnfjörð BjarmasonMay 9, 2017
  28. brian m. carlsonMay 9, 2017
  29. Johannes SchindelinMay 9, 2017
  30. Ævar Arnfjörð BjarmasonMay 9, 2017
  31. Ævar Arnfjörð BjarmasonMay 9, 2017
  32. demerphqMay 9, 2017
  33. Ævar Arnfjörð BjarmasonMay 9, 2017
  34. Brandon WilliamsMay 2, 2017
  35. Ævar Arnfjörð BjarmasonMay 2, 2017
  36. Ramsay JonesMay 5, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.