git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 4/4] fsmonitor: Delay updating state until after split index is merged

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 31, 2017, 05:24 UTC
Message-ID
<xmqqa80728lo.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<5cb81a33c31ffa585861f0d3f5a7c7eef5bd8fe0.1509146542.git.alexmv@dropbox.com>
Alex Vandiver <alexmv@dropbox.com> writes:
Show 23 quoted lines
> diff --git a/fsmonitor.c b/fsmonitor.c
> index 4ea44dcc6..417759224 100644
> --- a/fsmonitor.c
> +++ b/fsmonitor.c
> @@ -49,20 +49,7 @@ int read_fsmonitor_extension(struct index_state *istate, const void *data,
>  		ewah_free(fsmonitor_dirty);
>  		return error("failed to parse ewah bitmap reading fsmonitor index extension");
>  	}
> -
> -	if (git_config_get_fsmonitor()) {
> -		/* Mark all entries valid */
> -		for (i = 0; i < istate->cache_nr; i++)
> -			istate->cache[i]->ce_flags |= CE_FSMONITOR_VALID;
> -
> -		/* Mark all previously saved entries as dirty */
> -		ewah_each_bit(fsmonitor_dirty, fsmonitor_ewah_callback, istate);
> -
> -		/* Now mark the untracked cache for fsmonitor usage */
> -		if (istate->untracked)
> -			istate->untracked->use_fsmonitor = 1;
> -	}
> -	ewah_free(fsmonitor_dirty);
> +	istate->fsmonitor_dirty = fsmonitor_dirty;

This makes local variable "int i;" in this function unused and gets compiler warning.

Previous: Alex VandiverNext: Johannes Schindelin
Message 6 of 10 in “0/4 fsmonitor fixes”
  1. 0/4 fsmonitor fixesAlex Vandiver, Oct 27, 2017
  2. 1/4 fsmonitor: Set the PWD to the top of the working treeAlex Vandiver, Oct 27, 2017
  3. 2/4 fsmonitor: Don't bother pretty-printing JSON from watchmanAlex Vandiver, Oct 27, 2017
  4. 3/4 fsmonitor: Document GIT_TRACE_FSMONITORAlex Vandiver, Oct 27, 2017
  5. 4/4 fsmonitor: Delay updating state until after split index is mergedAlex Vandiver, Oct 27, 2017
  6. Junio C HamanoOct 31, 2017
  7. Johannes SchindelinOct 31, 2017
  8. Alex VandiverOct 31, 2017
  9. Johannes SchindelinOct 29, 2017
  10. Ben PeartOct 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.