git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 4/4] fsmonitor: Delay updating state until after split index is merged

From
AVAlex Vandiver <alexmv@dropbox.com>
Date
Oct 31, 2017, 18:43 UTC
Message-ID
<alpine.DEB.2.10.1710311139560.5248@alexmv-linux>
In-Reply-To
<alpine.DEB.2.21.1.1710311830330.6482@virtualbox>
On Tue, 31 Oct 2017, Junio C Hamano wrote:
> This makes local variable "int i;" in this function unused and gets
> compiler warning.

Apologies for leaving that detritus -- I saw you added a 'SQUASH??' commit to deal with it, which LGTM.

On Tue, 31 Oct 2017, Johannes Schindelin wrote:
> ... to which end we introduced the DEVELOPER flag to catch these: if you
> call
> 
> 	make DEVELOPER=1
Aha!  Thanks for the tip; I'll be sure to use that from now on.
 - Alex
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 8 of 10 in “0/4 fsmonitor fixes”
  1. 0/4 fsmonitor fixesAlex Vandiver, Oct 27, 2017
  2. 1/4 fsmonitor: Set the PWD to the top of the working treeAlex Vandiver, Oct 27, 2017
  3. 2/4 fsmonitor: Don't bother pretty-printing JSON from watchmanAlex Vandiver, Oct 27, 2017
  4. 3/4 fsmonitor: Document GIT_TRACE_FSMONITORAlex Vandiver, Oct 27, 2017
  5. 4/4 fsmonitor: Delay updating state until after split index is mergedAlex Vandiver, Oct 27, 2017
  6. Junio C HamanoOct 31, 2017
  7. Johannes SchindelinOct 31, 2017
  8. Alex VandiverOct 31, 2017
  9. Johannes SchindelinOct 29, 2017
  10. Ben PeartOct 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.