git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/4] fsmonitor: Set the PWD to the top of the working tree

From
AVAlex Vandiver <alexmv@dropbox.com>
Date
Oct 27, 2017, 23:26 UTC
Message-ID
<4b488da5e0710e9699f92d2dabe5e3352f3eb394.1509146542.git.alexmv@dropbox.com>
In-Reply-To
<20171027232637.30395-1-alexmv@dropbox.com>

The fsmonitor command inherits the PWD of its caller, which may be anywhere in the working copy. This makes is difficult for the fsmonitor command to operate on the whole repository. Specifically, for the watchman integration, this causes each subdirectory to get its own watch entry.

Set the CWD to the top of the working directory, for consistency.
Signed-off-by: Alex Vandiver <alexmv@dropbox.com>
---
 fsmonitor.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/fsmonitor.c b/fsmonitor.c
index 7c1540c05..4ea44dcc6 100644
--- a/fsmonitor.c
+++ b/fsmonitor.c
@@ -121,6 +121,7 @@ static int query_fsmonitor(int version, uint64_t last_update, struct strbuf *que
 	argv[3] = NULL;
 	cp.argv = argv;
 	cp.use_shell = 1;
+	cp.dir = get_git_work_tree();
 
 	return capture_command(&cp, query_result, 1024);
 }
-- 
2.15.0.rc1.413.g76aedb451
Previous: Alex VandiverNext: Alex Vandiver
Message 2 of 10 in “0/4 fsmonitor fixes”
  1. 0/4 fsmonitor fixesAlex Vandiver, Oct 27, 2017
  2. 1/4 fsmonitor: Set the PWD to the top of the working treeAlex Vandiver, Oct 27, 2017
  3. 2/4 fsmonitor: Don't bother pretty-printing JSON from watchmanAlex Vandiver, Oct 27, 2017
  4. 3/4 fsmonitor: Document GIT_TRACE_FSMONITORAlex Vandiver, Oct 27, 2017
  5. 4/4 fsmonitor: Delay updating state until after split index is mergedAlex Vandiver, Oct 27, 2017
  6. Junio C HamanoOct 31, 2017
  7. Johannes SchindelinOct 31, 2017
  8. Alex VandiverOct 31, 2017
  9. Johannes SchindelinOct 29, 2017
  10. Ben PeartOct 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.