git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1 2/4] config.mak.uname: support for modern HPE NonStop config.

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 28, 2018, 20:07 UTC
Message-ID
<xmqqa7kpmmtj.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<000601d49e0b$e11d7520$a3585f60$@rogers.com>
"Randall S. Becker" <randall.s.becker@rogers.com> writes:
Show 22 quoted lines
> On December 27, 2018 12:03, Eric Sunshine wrote:
>> On Wed, Dec 26, 2018 at 6:05 PM <randall.s.becker@rogers.com> wrote:
>> > A number of configuration options are not automatically detected by
>> > configure mechanisms, including the location of Perl and Python.
>> > [...]
>> > Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
>> > ---
>> > diff --git a/config.mak.uname b/config.mak.uname @@ -441,26 +441,45
>> @@
>> > ifeq ($(uname_S),NONSTOP_KERNEL)
>> >         # Our's are in ${prefix}/bin (perl might also be in /usr/bin/perl).
>> > -       PERL_PATH = ${prefix}/bin/perl
>> > -       PYTHON_PATH = ${prefix}/bin/python
>> > +       PERL_PATH = /usr/bin/perl
>> > +       PYTHON_PATH = /usr/bin/python
>> 
>> Is the in-code comment about ${prefix} still applicable after this change?
>
> The ${prefix} is not applicable on this platform for perl and
> python. Those locations must be in /usr/bin and are managed by the
> Operating System vendor not by customers. The change is wrapped in
> an IF so is only applicable to NonStop.

So the answer is "Our's are in ${prefix}/bin..." is no longer correct? If so, this patch must remove that stale comment at the same time, no?

Previous: Randall S. BeckerNext: Randall S. Becker
Message 8 of 15 in “HPE NonStop Port Commits”
  1. 0/4 HPE NonStop Port Commitsrandall.s.becker@rogers.com, Dec 26, 2018
  2. 1/4 transport-helper: use xread instead of readrandall.s.becker@rogers.com, Dec 26, 2018
  3. Junio C HamanoDec 28, 2018
  4. Randall S. BeckerDec 28, 2018
  5. 2/4 config.mak.uname: support for modern HPE NonStop config.randall.s.becker@rogers.com, Dec 26, 2018
  6. Eric SunshineDec 27, 2018
  7. Randall S. BeckerDec 27, 2018
  8. Junio C HamanoDec 28, 2018
  9. Randall S. BeckerDec 28, 2018
  10. 3/4 git-compat-util.h: add FLOSS headers for HPE NonStoprandall.s.becker@rogers.com, Dec 26, 2018
  11. Derrick StoleeDec 27, 2018
  12. Randall S. BeckerDec 27, 2018
  13. 4/4 compat/regex/regcomp.c: define intptr_t and uintptr_t on NonStoprandall.s.becker@rogers.com, Dec 26, 2018
  14. Derrick StoleeDec 27, 2018
  15. Randall S. BeckerDec 27, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.