Re: [PATCH v1 0/4] HPE NonStop Port Commits
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Dec 27, 2018, 12:12 UTC
- Message-ID
- <efa03ee9-b84f-5221-d811-1ccda9132007@gmail.com>
- In-Reply-To
- <20181226230523.16572-1-randall.s.becker@rogers.com>
On 12/26/2018 6:05 PM, randall.s.becker@rogers.com wrote:
Show 14 quoted lines
> From: "Randall S. Becker" <rsbecker@nexbridge.com> > > This set of patches is a distilled version of the minimal > set of changes to git that will allow it to run as client > and server on HPE NonStop NSE and NSX systems. NSR systems > are no longer under support so references to them have > been removed. Each patch in this set is independent but > required for correctness. > > Randall S. Becker (4): > transport-helper: use xread instead of read > config.mak.uname: support for modern HPE NonStop config. > git-compat-util.h: add FLOSS headers for HPE NonStop > compat/regex/regcomp.c: define intptr_t and uintptr_t on NonStop
These patches look correct to me. Just one question on patch 3 (git-compat-util.h: add FLOSS headers for HPE NonStop).
I'm not able to comment on patch 2 (config.mak.uname: support for modern HPE NonStop config.), but it looks to be wrapped in a platform-specific 'if', so should be fine if you are happy with it.
Thanks,
-Stolee