RE: [PATCH v1 2/4] config.mak.uname: support for modern HPE NonStop config.

From: Randall S. Becker <rsbecker@nexbridge.com>
Date: Dec 28, 2018, 20:33 UTC
Message-ID: <000f01d49eec$973d8990$c5b89cb0$@nexbridge.com>
In-Reply-To: <xmqqa7kpmmtj.fsf@gitster-ct.c.googlers.com>

On December 28, 2018 15:07, Junio C Hamano

Show 14 quoted lines

> "Randall S. Becker" <randall.s.becker@rogers.com> writes:
> 
> > On December 27, 2018 12:03, Eric Sunshine wrote:
> >> On Wed, Dec 26, 2018 at 6:05 PM <randall.s.becker@rogers.com> wrote:
> >> > A number of configuration options are not automatically detected by
> >> > configure mechanisms, including the location of Perl and Python.
> >> > [...]
> >> > Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> >> > ---
> >> > diff --git a/config.mak.uname b/config.mak.uname @@ -441,26
> +441,45
> >> @@
> >> > ifeq ($(uname_S),NONSTOP_KERNEL)
> >> >         # Our's are in ${prefix}/bin (perl might also be in

/usr/bin/perl).

Show 6 quoted lines

> >> > -       PERL_PATH = ${prefix}/bin/perl
> >> > -       PYTHON_PATH = ${prefix}/bin/python
> >> > +       PERL_PATH = /usr/bin/perl
> >> > +       PYTHON_PATH = /usr/bin/python
> >>
> >> Is the in-code comment about ${prefix} still applicable after this

change?

Show 7 quoted lines

> >
> > The ${prefix} is not applicable on this platform for perl and python.
> > Those locations must be in /usr/bin and are managed by the Operating
> > System vendor not by customers. The change is wrapped in an IF so is
> > only applicable to NonStop.
> 
> So the answer is "Our's are in ${prefix}/bin..." is no longer correct?  If

so, this

> patch must remove that stale comment at the same time, no?

Yessir. Fixed at v3 (now at v4).