Re: [PATCH v3 0/6] perf-lib.sh: fix 0baf78e7bc regression, refactor & fix bugs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 8, 2019, 01:59 UTC
- Message-ID
- <xmqqa7fxk8ot.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190507213612.GB19955@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> I think this is reasonable, especially with the feature in patch 6 to > tell the caller they're doing it wrong, instead of just silently > producing nonsense results. > > Junio, if you haven't been following closely, this can replace my patch > from jk/perf-installed-fix.
I did not pick up v2 or earlier as it wasn't clear what the resolution would be, but I agree that this round looks sensible.
Thanks for the hint; very very much appreciated.