Re: js/partial-clone-connectivity-check (was: What's cooking in git.git (Apr 2019, #05; Thu, 25))

From: Jeff King <peff@peff.net>
Date: May 2, 2019, 02:52 UTC
Message-ID: <20190502025206.GA25395@sigill.intra.peff.net>
In-Reply-To: <20190425221657.GV60888@google.com>

On Thu, Apr 25, 2019 at 03:16:57PM -0700, Josh Steadmon wrote:

Show 16 quoted lines

> On 2019.04.25 19:15, Junio C Hamano wrote:
> > * js/partial-clone-connectivity-check (2019-04-21) 1 commit
> >   (merged to 'next' on 2019-04-25 at ebd8b4bffd)
> >  + clone: do faster object check for partial clones
> > 
> >  During an initial "git clone --depth=..." partial clone, it is
> >  pointless to spend cycles for a large portion of the connectivity
> >  check that enumerates and skips promisor objects (which by
> >  definition is all objects fetched from the other side).  This has
> >  been optimized out.
> > 
> >  Will merge to 'master'.
> 
> Peff asked for a perf test for this [1], but I haven't had time to write one
> yet. I can do that in a separate patch if you still want to merge this
> as-is.

I won't die without one, but it would be nice. It may also be that an existing perf test, but I don't think we cover partial clones in t/perf at all. Might be worth just a straight-up "git clone --filter=blob:none" test.

Also, in the proposed merge message above, it should be --filter, not --depth, right?

-Peff