Re: [PATCH v2 1/2] perf-lib.sh: make "./run <revisions>" use the correct gits

From: Jeff King <peff@peff.net>
Date: May 7, 2019, 07:19 UTC
Message-ID: <20190507071929.GC28060@sigill.intra.peff.net>
In-Reply-To: <20190506232309.28538-2-avarab@gmail.com>

On Tue, May 07, 2019 at 01:23:08AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 15 quoted lines

> diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
> index 169f92eae3..b15ee1d262 100644
> --- a/t/perf/perf-lib.sh
> +++ b/t/perf/perf-lib.sh
> @@ -32,6 +32,10 @@ TEST_NO_MALLOC_CHECK=t
>  if test -z "$GIT_TEST_INSTALLED"; then
>  	perf_results_prefix=
>  else
> +	if test -n "$GIT_PERF_DIR_MYDIR_REL"
> +	then
> +		GIT_TEST_INSTALLED=$GIT_PERF_DIR_MYDIR_REL
> +	fi
>  	perf_results_prefix=$(printf "%s" "${GIT_TEST_INSTALLED%/bin-wrappers}" | tr -c "[a-zA-Z0-9]" "[_*]")"."
>  	GIT_TEST_INSTALLED=$ABSOLUTE_GIT_TEST_INSTALLED
>  fi

I still like my fix better, as it works completely within perf-lib.sh, and so is a more direct fix. And doesn't have this weird exported MYDIR_ABS that nobody actually uses.

But I don't actually think this topic is worth spending too many brain cycles on. So I am fine with either fix, as long as we do something.

-Peff