git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: coccinelle: adjustments for array.cocci?

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 13, 2019, 02:11 UTC
Message-ID
<xmqqa790cyp1.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<5189f847-1af1-f050-6c72-576a977f6f12@web.de>
René Scharfe <l.s.r@web.de> writes:
> This reduces duplication in the semantic patch, which is nice.  I think
> I tried something like that at the time, but found that it failed to
> produce some of the cases in 921d49be86 ("use COPY_ARRAY for copying
> arrays", 2019-06-15) for some reason.
Thanks for mentioning.

I too recall that seemingly redundant entries were noticed during the review and at least back then removing the seemingly redundant ones caused failures in rewriting.

That is why I am hesitant to touch any patch that says "simplify cocci rule" making it sound as if simplification is a good thing on its own. I have no problem with "we change the rule this way, which eliminates this false positive / negative, that is demonstrated in the added tests in t/ directory", though.

Thanks.
Previous: René ScharfeNext: Markus Elfring
Message 3 of 41 in “coccinelle: adjustments for array.cocci?”
  1. Markus ElfringNov 12, 2019
  2. René ScharfeNov 12, 2019
  3. Junio C HamanoNov 13, 2019
  4. Markus ElfringNov 13, 2019
  5. Junio C HamanoNov 14, 2019
  6. Markus ElfringNov 14, 2019
  7. René ScharfeNov 14, 2019
  8. Markus ElfringNov 14, 2019
  9. René ScharfeNov 14, 2019
  10. Markus ElfringNov 15, 2019
  11. Markus ElfringNov 15, 2019
  12. Markus ElfringNov 15, 2019
  13. Julia LawallNov 16, 2019
  14. Markus ElfringNov 16, 2019
  15. Markus ElfringNov 16, 2019
  16. Julia LawallNov 16, 2019
  17. Markus ElfringNov 16, 2019
  18. Markus ElfringNov 15, 2019
  19. René ScharfeNov 16, 2019
  20. Markus ElfringNov 17, 2019
  21. René ScharfeNov 17, 2019
  22. Markus ElfringNov 17, 2019
  23. René ScharfeNov 19, 2019
  24. Markus ElfringNov 19, 2019
  25. René ScharfeNov 21, 2019
  26. Markus ElfringNov 16, 2019
  27. René ScharfeNov 16, 2019
  28. Markus ElfringNov 17, 2019
  29. René ScharfeNov 17, 2019
  30. Markus ElfringNov 17, 2019
  31. René ScharfeNov 19, 2019
  32. coccinelle: improve array.cocciMarkus Elfring, Nov 18, 2019
  33. René ScharfeNov 19, 2019
  34. Markus ElfringNov 20, 2019
  35. René ScharfeNov 21, 2019
  36. Markus ElfringNov 21, 2019
  37. SZEDER GáborNov 22, 2019
  38. Markus ElfringNov 22, 2019
  39. Junio C HamanoNov 22, 2019
  40. Markus ElfringNov 22, 2019
  41. Markus ElfringJan 25, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.