Re: coccinelle: adjustments for array.cocci?

From: René Scharfe <l.s.r@web.de>
Date: Nov 14, 2019, 17:46 UTC
Message-ID: <aed296a6-bae0-6fcc-515e-ef96fed24ca6@web.de>
In-Reply-To: <6c4ef61f-5fef-ffc8-82d6-ee42006756b4@web.de>

Am 14.11.19 um 18:14 schrieb Markus Elfring:

Show 17 quoted lines

>> If the new version of array.cocci is equivalent to the current one then
>> that last step should show no difference.
>
> I hoped it.
>
>
>>  contrib/coccinelle/array.cocci | 30 ++++++++++++++----------------
>>  fast-import.c                  |  2 +-
>>  packfile.c                     |  4 ++--
>>  pretty.c                       |  4 ++--
>>  4 files changed, 19 insertions(+), 21 deletions(-)
>>
>> The changes in array.cocci are expected of course, but the others
>> indicate that the new version missed transformations that the current
>> version generated.
>
> Would we like to submit a bug report for the Coccinelle software?

Not really, because...

> Which version did you try out for the comparison of generated patches?

... I use the last version of the Debian testing package, 1.0.4.deb-4. https://tracker.debian.org/pkg/coccinelle says it was removed from testing recently. I was actually waiting for a more recent version like 1.0.8 to be packaged; not sure what's going on there.

Anyway, someone who can reproduce the issue using the latest release of Coccinelle would be in a better position to file a bug report.

René