Re: [PATCH 1/2] doc: update the documentation of pack-objects and repack

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 3, 2020, 22:29 UTC
Message-ID: <xmqqa74x6pj3.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200303212302.znhumbjo7lywyhvh@doriath>

Damien Robert <damien.olivier.robert@gmail.com> writes:

> So do you suggest instead to remove all references to 'git-pack-objects'
> in 'git-repack'?

Not really.  If you are trying to remedy ...

> This is a high level overview, but the user who knows a bit about Git
> internals may wonder what exactly 'all' entails: non local objects, kept
> objects, promisor objects, unreachable objects?

... this kind of thing, I do not think that a solution that is the best for readers is not this:

> Knowing that the default options passed are:
> `--keep-true-parents`, `--all`, `--reflog`, `--indexed-objects`, `--exclude-promisor-objects`

that requires them to go down and read what --indexed-objects (for example) means in the documentation for "git pack-objects" command, and piece together what they mean when they are used together.

> answers this questions: it is essentially all objects except unreachable ones.

Yes, "all objects except unreachable ones", which you came up with, is a good description, I would think.