Re: [PATCH v3 00/12] Finish converting git bisect to C part 2

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 23, 2020, 20:01 UTC
Message-ID: <xmqqa732gee8.fsf@gitster.c.googlers.com>
In-Reply-To: <20200423070704.39872-1-mirucam@gmail.com>

Miriam Rubio <mirucam@gmail.com> writes:

Show 6 quoted lines

> --- Changes since v2 Finish converting git bisect to C part 2 patch series ---
>
> General changes
> ---------------
>
> * Rebase on master branch: efe3874640 (Sync with v2.26.1, 2020-04-13)

Was there a particular reason why you needed to do this rebase? It seems that the patches apply cleanly on the same base as v2 has been queued? Does the result cause hard-to-resolve conflicts when merged to the 'master', 'next' or 'pu' branches unless you do that rebase?

Show 6 quoted lines

> Specific changes
> ----------------
>
> [1/12] bisect--helper: fix `cmd_*()` function switch default return
>
> * Use `BUG()` instead of `return error()` in default switch.

This rings a bell.  range-diff looks good.

> [2/12] bisect--helper: use '-res' in 'cmd_bisect__helper' return
>
> * New patch: use '-res' instead of 'abs(res)'.

Alright.

Show 6 quoted lines

> [3/12] bisect--helper: introduce new `write_in_file()` function
>
> * Rename input parameter `filepath` to `path`.
> * Change `error_errno()` to `error()` in mode checking.
> * Change error message when file cannot be opened.
> * Add `fclose()` before error return.

OK. I am not sure if the error behaviour when fclose() fails is ideal, but I do not think it is worth further polishing.

Show 5 quoted lines

> [4/12] bisect--helper: reimplement `bisect_autostart` shell function in C
>
> * Reorder patch before `reimplement `bisect_next` and `bisect_auto_next`
> shell functions in C` to use `bisect_autostart()` function in 
> `bisect_append_log_quoted()`.

OK.

Will take a look at individual patches later.

Thanks.