git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 00/12] Finish converting git bisect to C part 2

From
Miriam Rubio <mirucam@gmail.com>
Date
Apr 23, 2020, 07:06 UTC
Message-ID
<20200423070704.39872-1-mirucam@gmail.com>

These patches correspond to a second part of patch series of Outreachy project "Finish converting `git bisect` from shell to C" started by Pranit Bauva and Tanushree Tumane (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and continued by me.

These patch series emails were generated from: https://gitlab.com/mirucam/git/commits/git-bisect-work-part2-v3.

I would like to thank Junio Hamano for reviewing this patch series and Christian Couder for his help.

--- Changes since v2 Finish converting git bisect to C part 2 patch series ---

General changes ---------------

* Rebase on master branch: efe3874640 (Sync with v2.26.1, 2020-04-13)

Specific changes ----------------

[1/12] bisect--helper: fix `cmd_*()` function switch default return
* Use `BUG()` instead of `return error()` in default switch.
--
[2/12] bisect--helper: use '-res' in 'cmd_bisect__helper' return
* New patch: use '-res' instead of 'abs(res)'.
--
[3/12] bisect--helper: introduce new `write_in_file()` function
* Rename input parameter `filepath` to `path`.
* Change `error_errno()` to `error()` in mode checking.
* Change error message when file cannot be opened.
* Add `fclose()` before error return.
--
[4/12] bisect--helper: reimplement `bisect_autostart` shell function in C
* Reorder patch before `reimplement `bisect_next` and `bisect_auto_next`
shell functions in C` to use `bisect_autostart()` function in 
`bisect_append_log_quoted()`.

-- ` [5/12] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in C

* Amend commit message.
* Add `clear_commit_marks()` at the end of bisect_next_all() and remove it from 
`bisect_rev_setup()`.
* Fix if condition.
* Add `bisect_autostart()` in `bisect_append_log_quoted()`.
* Check `git_path_bisect_head()` with `file_exist()` instead of 
`is_empty_or_missing_file()`.
* Fix return with BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND.
* Add conversion in `cmd_*()` to BISECT_OK when return is 
BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND.
* Note to previous reviewer: suggestion to change `bisect_auto_next()` function
to return void cannot be done because errors from `bisect_next()` are not 
ignored.
--

[5/12] bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in C

* Check `git_path_bisect_head()` with `file_exist()` instead of 
`is_empty_or_missing_file()`.
--
Miriam Rubio (3):
  bisect--helper: fix `cmd_*()` function switch default return
  bisect--helper: use '-res' in 'cmd_bisect__helper' return
  bisect--helper: introduce new `write_in_file()` function
Pranit Bauva (9):
  bisect--helper: reimplement `bisect_autostart` shell function in C
  bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell
    functions in C
  bisect--helper: finish porting `bisect_start()` to C
  bisect--helper: retire `--bisect-clean-state` subcommand
  bisect--helper: retire `--next-all` subcommand
  bisect--helper: reimplement `bisect_state` & `bisect_head` shell
    functions in C
  bisect--helper: retire `--check-expected-revs` subcommand
  bisect--helper: retire `--write-terms` subcommand
  bisect--helper: retire `--bisect-autostart` subcommand
 bisect.c                 |   8 +
 builtin/bisect--helper.c | 383 +++++++++++++++++++++++++++++++++------
 git-bisect.sh            | 145 +--------------
 3 files changed, 347 insertions(+), 189 deletions(-)
-- 
2.25.0
Next: Miriam Rubio
Message 1 of 28 in “Finish converting git bisect to C part 2”
  1. 00/12 Finish converting git bisect to C part 2Miriam Rubio, Apr 23, 2020
  2. 01/12 bisect--helper: fix `cmd_*()` function switch default returnMiriam Rubio, Apr 23, 2020
  3. Johannes SchindelinMay 22, 2020
  4. 03/12 bisect--helper: introduce new `write_in_file()` functionMiriam Rubio, Apr 23, 2020
  5. Johannes SchindelinMay 22, 2020
  6. Đoàn Trần Công DanhMay 23, 2020
  7. 02/12 bisect--helper: use '-res' in 'cmd_bisect__helper' returnMiriam Rubio, Apr 23, 2020
  8. Johannes SchindelinMay 22, 2020
  9. 04/12 bisect--helper: reimplement `bisect_autostart` shell function in CMiriam Rubio, Apr 23, 2020
  10. Johannes SchindelinMay 22, 2020
  11. Johannes SchindelinMay 22, 2020
  12. 05/12 bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in CMiriam Rubio, Apr 23, 2020
  13. Johannes SchindelinMay 22, 2020
  14. 07/12 bisect--helper: retire `--bisect-clean-state` subcommandMiriam Rubio, Apr 23, 2020
  15. 06/12 bisect--helper: finish porting `bisect_start()` to CMiriam Rubio, Apr 23, 2020
  16. Johannes SchindelinMay 22, 2020
  17. 08/12 bisect--helper: retire `--next-all` subcommandMiriam Rubio, Apr 23, 2020
  18. 10/12 bisect--helper: retire `--check-expected-revs` subcommandMiriam Rubio, Apr 23, 2020
  19. 09/12 bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in CMiriam Rubio, Apr 23, 2020
  20. Johannes SchindelinMay 22, 2020
  21. Miriam R.Jun 20, 2020
  22. Johannes SchindelinJun 19, 2020
  23. 11/12 bisect--helper: retire `--write-terms` subcommandMiriam Rubio, Apr 23, 2020
  24. 12/12 bisect--helper: retire `--bisect-autostart` subcommandMiriam Rubio, Apr 23, 2020
  25. Junio C HamanoApr 23, 2020
  26. Miriam R.Apr 25, 2020
  27. Johannes SchindelinMay 22, 2020
  28. Miriam R.May 24, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.