Re: [PATCH v3 01/12] bisect--helper: fix `cmd_*()` function switch default return
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 22, 2020, 13:14 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2005221513060.56@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20200423070704.39872-2-mirucam@gmail.com>
Hi Miriam,
On Thu, 23 Apr 2020, Miriam Rubio wrote:
Show 5 quoted lines
> In a `cmd_*()` function, return `error()` cannot be used > because that translates to `-1` and `cmd_*()` functions need > to return exit codes. > > Let's fix switch default return.
I think there is an even stronger argument for not returning here: it actually _would_ be a bug, not a user error, if the `default` branch was reached.
The patch looks good.
Ciao, Dscho
Show 25 quoted lines
>
> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Signed-off-by: Miriam Rubio <mirucam@gmail.com>
> ---
> builtin/bisect--helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
> index c1c40b516d..a81a2c76ff 100644
> --- a/builtin/bisect--helper.c
> +++ b/builtin/bisect--helper.c
> @@ -711,7 +711,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
> res = bisect_start(&terms, no_checkout, argv, argc);
> break;
> default:
> - return error("BUG: unknown subcommand '%d'", cmdmode);
> + BUG("unknown subcommand %d", (int)cmdmode);
> }
> free_terms(&terms);
>
> --
> 2.25.0
>
>