Re: [PATCH v2 0/11] fast-export: allow seeding the anonymized mapping

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 25, 2020, 21:22 UTC
Message-ID: <xmqqa70q4z8i.fsf@gitster.c.googlers.com>
In-Reply-To: <20200625194802.GA4028913@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

>   [09/11]: fast-export: allow seeding the anonymized mapping
>
>     - the option is now called "--anonymize-map", and the word "seed"
>       isn't used in any user-facing documentation
>
>     - incorporated Eric's documentation suggestions
>
>     - --anonymize-map without --anonymize now triggers an error

The changes compared to the v1 here looked sensible.

Show 11 quoted lines

>   [10/11]: fast-export: anonymize "master" refname
>
>     - minor adjustments to handle change of option name
>
>   [11/11]: fast-export: use local array to store anonymized oid
>
>     - new in this iteration; this address the gcc-4 warning that Gábor
>       mentioned. I prepared it on top since I think we'd eventually want
>       to revert it once we decide that compiler is too old (and I'd be
>       perfectly fine to declare that it's so now, and just never apply
>       it at all).

Sounds like a sensible way.

Let's merge it to 'next' soonish.

Thanks, all.