Re: [PATCH 09/10] fast-export: allow seeding the anonymized mapping

From: Jeff King <peff@peff.net>
Date: Jun 24, 2020, 15:48 UTC
Message-ID: <20200624154853.GB2088459@coredump.intra.peff.net>
In-Reply-To: <CAPig+cTBwZJnUYqeEjXp-hAOjHb783B+9kyy+h+HtiOTy_c_hg@mail.gmail.com>

On Tue, Jun 23, 2020 at 04:35:37PM -0400, Eric Sunshine wrote:

Show 9 quoted lines

> > I wrestled with the name, and I agree "seed" is overly technical. And I
> > came up with many similar variations of "anonymize-to", but they all
> > seemed ambiguous (e.g., it could be "to" a file that we're storing the
> > data in).
> >
> > Perhaps "--anonymize-map" would be less technical?
> 
> That's not too bad. It is better than --seed-anonymized. I haven't
> come up with any name which improves upon it.

I went with that in my reroll, and avoided using the word "seed" at all in the documentation (I did keep the name "anonymized_seeds" as the internal variable name for the hashmap, since just calling it "map" there is ambiguous with all of the other maps).

-Peff