Re: [PATCH v5 07/11] maintenance: take a lock on the objects directory

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 21, 2020, 19:29 UTC
Message-ID: <xmqqa6xjexn1.fsf@gitster.c.googlers.com>
In-Reply-To: <368d7c1f-b8b2-8bed-ead4-047019125435@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 7 quoted lines

>> With this as an entry point we'll entirely do away with the old one
>> since we don't use the "gc --auto" entry point.
>
> Users could still erroneously launch two `git gc` commands concurrently
> and that will not use the maintenance.lock file. The GC lock is worth
> keeping around until we redirect the `gc` command to be an alias that
> runs `git maintenance run --task=gc [options]`.

Yes, that is prudent. And as long as the traditional gc lock stops the maintenance command from running the gc task, everthing would work consistently ;-)

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.