git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ci: run `make sparse` as a GitHub workflow

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 14, 2021, 20:56 UTC
Message-ID
<xmqqa6movcly.fsf@gitster.g>
In-Reply-To
<nycvar.QRO.7.76.6.2107142252060.59@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 28 quoted lines
> Hi Junio,
>
> On Wed, 14 Jul 2021, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>> > Which means that the likelihood of a run to fail increases with the number
>> > of jobs in said run (even innocuous problems such as transient failures to
>> > download an Ubuntu package), and it also makes it much more painful to
>> > re-run the entire thing because you may well end up wasting a grand total
>> > of ~370 minutes even if only a 30-second-job would need to be re-run.
>> >
>> > Having said that, I think you're right and the upside of keeping things
>> > together may outweigh that downside.
>>
>> I wasn't make a request or a demand to change or not to change
>> anything, so in this particular exchange there was no point where I
>> was right (or wrong, for that matter ;-).  I was asking if there was
>> a solid reasoning behind the split, and if there is, I am perfectly
>> happy to see it done as a separate workflow with the log message
>> that explains why it is separate.  I am also perfectly fine with
>> this rolled into the primary one, with clear reasoning behind the
>> choice recorded in the log message.
>
> I do not think that it would be an improvement to defend the default
> choice (i.e. to add this new job to `.github/workflows/main.yml`) in the
> commit message. It is the default for new CI stuff to go, after all, and
> we do not need to clutter the message by stating the obvious.

It wasn't quite obvious why we justify spending 370 minutes one more time only to rerun 30-second job, though.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 12 of 22 in “ci: run `make sparse` as a GitHub workflow”
  1. ci: run `make sparse` as a GitHub workflowJohannes Schindelin via GitGitGadget, Jul 13, 2021
  2. Đoàn Trần Công DanhJul 13, 2021
  3. Johannes SchindelinJul 14, 2021
  4. Philippe BlainJul 13, 2021
  5. Johannes SchindelinJul 14, 2021
  6. Johannes SchindelinJul 14, 2021
  7. Ramsay JonesJul 16, 2021
  8. Junio C HamanoJul 13, 2021
  9. Johannes SchindelinJul 14, 2021
  10. Junio C HamanoJul 14, 2021
  11. Johannes SchindelinJul 14, 2021
  12. Junio C HamanoJul 14, 2021
  13. Johannes SchindelinJul 14, 2021
  14. Junio C HamanoJul 14, 2021
  15. Johannes SchindelinJul 16, 2021
  16. Junio C HamanoJul 16, 2021
  17. ci: run `make sparse` as part of the GitHub workflowJohannes Schindelin via GitGitGadget, Jul 14, 2021
  18. ci: run "apt-get update" before "apt-get install"Jeff King, Jul 26, 2021
  19. Jeff KingJul 26, 2021
  20. Junio C HamanoJul 26, 2021
  21. ci: run `make sparse` as part of the GitHub workflowJohannes Schindelin via GitGitGadget, Jul 26, 2021
  22. Junio C HamanoJul 26, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.