Re: [PATCH] ci: run `make sparse` as a GitHub workflow

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Jul 13, 2021, 17:34 UTC
Message-ID: <f305f586-c3ac-a2ef-8769-5468a4c3e539@gmail.com>
In-Reply-To: <pull.994.git.1626177086682.gitgitgadget@gmail.com>

Hi Dscho,

Le 2021-07-13 à 07:51, Johannes Schindelin via GitGitGadget a écrit :

Show 7 quoted lines

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> Occasionally we receive reviews after patches were integrated, where
> `sparse` identified problems such as file-local variables or functions
> being declared as global.
> 
> By running `sparse`

maybe here, we could add a link to https://sparse.docs.kernel.org/en/latest/, so interested readers who do not know about "sparse" can go and learn about it ?

Show 8 quoted lines

> as part of our Continuous Integration, we can catch
> such things much earlier. Even better: developers who activated GitHub
> Actions on their forks can catch such issues before even sending their
> patches to the Git mailing list.
> 
> This addresses https://github.com/gitgitgadget/git/issues/345
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Show 8 quoted lines

> +    - name: Download the `sparse` package
> +      uses: git-for-windows/get-azure-pipelines-artifact@v0
> +      with:
> +        repository: git/git
> +        definitionId: 10
> +        artifact: sparse-20.04
> +    - name: Install the `sparse` package
> +      run: sudo dpkg -i sparse-20.04/sparse_*.deb

Out of curiosity, why is this necessary (as opposed to using the Ubuntu package, i.e. 'sudo apt-get -q -y sparse') ?

Thanks, Philippe.