[PATCH] ci: run "apt-get update" before "apt-get install"
- From
Jeff King <peff@peff.net>
- Date
- Jul 26, 2021, 17:53 UTC
- Message-ID
- <YP72o/1Yg02BcDXw@coredump.intra.peff.net>
- In-Reply-To
- <pull.994.v2.git.1626263433838.gitgitgadget@gmail.com>
On Wed, Jul 14, 2021 at 11:50:33AM +0000, Johannes Schindelin via GitGitGadget wrote:
> + - name: Install other dependencies > + run: | > + sudo apt-get install -q -y libssl-dev libcurl4-openssl-dev libexpat-dev gettext zlib1g-dev
My CI runs based on 'next' started failing today. I think we'd want this on top (of js/ci-make-sparse):
-- >8 -- Subject: [PATCH] ci: run "apt-get update" before "apt-get install"
The "sparse" workflow runs "apt-get install" to pick up a few necessary packages. But it needs to run "apt-get update" first, or it risks trying to download an old package version that no longer exists. And in fact this happens now, with output like:
2021-07-26T17:40:51.2551880Z E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/c/curl/libcurl4-openssl-dev_7.68.0-1ubuntu2.5_amd64.deb 404 Not Found [IP: 52.147.219.192 80] 2021-07-26T17:40:51.2554304Z E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Our other ci jobs don't suffer from this; they rely on scripts in ci/, and ci/install-dependencies does the appropriate "apt-get update".
Signed-off-by: Jeff King <peff@peff.net> --- I guess this package setup could also be moved into ci/install-dependencies.sh, but I don't think it really buys anything (the "apt-get update" line would not even be shared, because the outermost layer is a big switch statement on the jobname). OTOH, it looks like other one-off jobs are in there (e.g., StaticAnalysis).
Anyway, this is the minimal fixup.
.github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1b5c039207..01878884ae 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -368,6 +368,7 @@ jobs: run: sudo dpkg -i sparse-20.04/sparse_*.deb - name: Install other dependencies run: | + sudo apt-get update -q && sudo apt-get install -q -y libssl-dev libcurl4-openssl-dev libexpat-dev gettext zlib1g-dev - uses: actions/checkout@v2 - run: make sparse
-- 2.32.0.805.g1fa0022869