Re: [PATCH v6 1/6] object-file.c: release strbuf in write_loose_object()

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 18, 2021, 00:09 UTC
Message-ID: <xmqqa6gy22py.fsf@gitster.g>
In-Reply-To: <c860c56f-ce25-4391-7f65-50c9d5d80c2c@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 14 quoted lines

> There was no leak before.  Both strbufs are static and both functions
> they are passed to (loose_object_path() and create_tmpfile()) reset
> them first.  So while the allocated memory was not released before,
> it was reused.
>
> Not sure if making write_loose_object() allocate and release these
> buffers on every call has much of a performance impact.  The only
> reason I can think of for wanting such a change is to get rid of the
> static buffers, to allow the function to be used by concurrent
> threads.
>
> So I think either keeping the code as-is or also making the strbufs
> non-static would be better (but then discussing a possible
> performance impact in the commit message would be nice).

Makes sense.