Re: [PATCH v3 5/5] unpack-objects: unpack_non_delta_entry() read data in a stream
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Dec 2, 2021, 13:53 UTC
- Message-ID
- <993f83e8-cb53-cad2-8457-e8e94ac56ca2@gmail.com>
- In-Reply-To
- <CAO0brD2bGXwAJVrPSybbVNeSmQ1S85a_ykmceVKrg=pE3MfsnA@mail.gmail.com>
On 12/2/2021 2:33 AM, Han Xin wrote:
Show 15 quoted lines
> On Wed, Dec 1, 2021 at 2:38 AM Derrick Stolee <stolee@gmail.com> wrote: >> These pack-files contain (mostly) small objects, no large blobs. >> I know that's not the target of your efforts, but it would be >> good to avoid a regression here. >> >> Thanks, >> -Stolee > > With your help, I did catch this performance problem, which was > introduced in this patch: > https://lore.kernel.org/git/20211122033220.32883-4-chiyutianyi@gmail.com/ > > This patch changes the original data reading ino to stream reading, but > its problem is that even for the original reading of the whole object data, > it still generates an additional git_deflate() and subsequent transfer.
I'm glad you found it!
> I will fix it in a follow-up patch.
Looking forward to it.
Thanks, -Stolee