Re: [PATCH v4 0/5] unpack large objects in stream

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 7, 2021, 16:18 UTC
Message-ID: <8594ac5f-8c09-6959-2bc7-208f6d888b4b@gmail.com>
In-Reply-To: <20211203093530.93589-1-chiyutianyi@gmail.com>

On 12/3/2021 4:35 AM, Han Xin wrote:

Show 10 quoted lines

> From: Han Xin <hanxin.hx@alibaba-inc.com>
> 
> Changes since v3:
> * Add "size" to "struct input_stream" which used by following commits.
> 
> * Increase the buffer size of "struct input_zstream_data" from 4096 to
>   8192, which is consistent with the "fixed_buf" in the "index-pack.c".
> 
> * Refactor "read stream in a loop in write_loose_object()" which
>   introduced a performance problem reported by Derrick Stolee[1].

Thank you for finding the issue. It seems simple enough to add that size information and regain the performance back to nearly no overhead. Your hyperfine statistics are within noise, which is great. Thanks!

-Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.