Re: [PATCH v4 0/5] Sparse index: fetch, pull, ls-files
Elijah Newren <newren@gmail.com> writes:
Show 43 quoted lines
> On Wed, Dec 22, 2021 at 6:20 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> This is now based on 'master'.
>>
>> Did you know that 'fetch' and 'pull' read the index? I didn't, or this would
>> have been an integration much earlier in the cycle. They read the index to
>> look for the .gitmodules file in case there are submodules that need to be
>> fetched. Since looking for a file by name is already protected, we only need
>> to disable 'command_requires_full_index' and we are done.
>>
>> The 'ls-files' builtin is useful when debugging the index, and some scripts
>> use it, too. We are not changing the default behavior which expands a sparse
>> index in order to show all of the cached blobs. Instead, we add a '--sparse'
>> option that allows us to see the sparse directory entries upon request.
> ...
>> Updates in v2
>> =============
>>
>> * Rebased onto latest ld/sparse-index-blame without issue.
>> * Updated the test to use diff-of-diffs instead of a sequence of greps.
>> * Added patches that remove the use of 'test-tool read-cache --table' and
>> its implementation.
>>
>>
>> Updates in v3
>> =============
>>
>> * Fixed typo in commit message.
>> * Added comments around doing strange things in an ls-files test.
>> * Fixed adjacent typo in a test comment.
>>
>>
>> Updates in v4
>> =============
>>
>> * Rebased on to 'master' now that ld/sparse-index-blame is merged.
>> * Change testing strategy to check exact output instead of using 'diff -u'.
>> * Updated documentation to state that directories have a trailing slash.
>
> This version looks good to me:
>
> Reviewed-by: Elijah Newren <newren@gmail.com>
Yup, they looked good to me too.
Thanks.