git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] ls-files: add --sparse option

From
Derrick Stolee <stolee@gmail.com>
Date
Dec 16, 2021, 14:11 UTC
Message-ID
<3910553a-019c-24bf-a058-ef47dfe28393@gmail.com>
In-Reply-To
<xmqq7dc8co3d.fsf@gitster.g>
On 12/13/2021 2:16 PM, Junio C Hamano wrote:
Show 23 quoted lines
> Derrick Stolee <stolee@gmail.com> writes:
> 
>> You're talking about this hunk, right?
>>
>> if test -z "$GIT_TEST_CMP"
>> then
>> 	if test -n "$GIT_TEST_CMP_USE_COPIED_CONTEXT"
>> 	then
>> 		GIT_TEST_CMP="$DIFF -c"
>> 	else
>> 		GIT_TEST_CMP="$DIFF -u"
>> 	fi
>> fi
>>
>> This only switches from "diff -u" to "diff -c" if the
>> GIT_TEST_CMP_USE_COPIED_CONTEXT variable is set, but it is not set
>> by default. Thus, we are using "diff -u" by default throughout.
> 
> That it can be set merely means that somebody needed to work around
> the lack of "-u" format in their implementation of "diff".  It came
> to POSIX only at the Issue 7 of the standard (cf. [*1*]).
> 
> Unconditional use of "diff -u" is a breaking change for them.

Yes, noted. I'm currently waiting for ld/sparse-diff-blame to merge to 'master' before sending a new version, since there are unrelated build failures without taking newer changes in 'master'.

Thanks, -Stolee

Previous: Junio C HamanoNext: Junio C Hamano
Message 17 of 51 in “Sparse index: fetch, pull, ls-files”
  1. 0/2 Sparse index: fetch, pull, ls-filesDerrick Stolee via GitGitGadget, Nov 16, 2021
  2. 1/2 fetch/pull: use the sparse indexDerrick Stolee via GitGitGadget, Nov 16, 2021
  3. 2/2 ls-files: add --sparse optionDerrick Stolee via GitGitGadget, Nov 16, 2021
  4. Elijah NewrenNov 22, 2021
  5. Derrick StoleeNov 22, 2021
  6. Ævar Arnfjörð BjarmasonNov 23, 2021
  7. Derrick StoleeDec 8, 2021
  8. Derrick StoleeDec 8, 2021
  9. Elijah NewrenDec 8, 2021
  10. Derrick StoleeDec 8, 2021
  11. Elijah NewrenDec 8, 2021
  12. Derrick StoleeDec 8, 2021
  13. Ævar Arnfjörð BjarmasonDec 9, 2021
  14. Derrick StoleeDec 10, 2021
  15. Ævar Arnfjörð BjarmasonDec 10, 2021
  16. Junio C HamanoDec 13, 2021
  17. Derrick StoleeDec 16, 2021
  18. Junio C HamanoNov 17, 2021
  19. Derrick StoleeNov 17, 2021
  20. Junio C HamanoNov 18, 2021
  21. Ævar Arnfjörð BjarmasonNov 23, 2021
  22. 0/5 Sparse index: fetch, pull, ls-filesDerrick Stolee via GitGitGadget, Dec 8, 2021
  23. 1/5 fetch/pull: use the sparse indexDerrick Stolee via GitGitGadget, Dec 8, 2021
  24. 2/5 ls-files: add --sparse optionDerrick Stolee via GitGitGadget, Dec 8, 2021
  25. Elijah NewrenDec 9, 2021
  26. Derrick StoleeDec 10, 2021
  27. 3/5 t1092: replace 'read-cache --table' with 'ls-files --sparse'Derrick Stolee via GitGitGadget, Dec 8, 2021
  28. Elijah NewrenDec 9, 2021
  29. 4/5 t1091/t3705: remove 'test-tool read-cache --table'Derrick Stolee via GitGitGadget, Dec 8, 2021
  30. Elijah NewrenDec 9, 2021
  31. 5/5 test-read-cache: remove --table, --expand optionsDerrick Stolee via GitGitGadget, Dec 8, 2021
  32. Elijah NewrenDec 9, 2021
  33. 0/5 Sparse index: fetch, pull, ls-filesDerrick Stolee via GitGitGadget, Dec 10, 2021
  34. 1/5 fetch/pull: use the sparse indexDerrick Stolee via GitGitGadget, Dec 10, 2021
  35. 2/5 ls-files: add --sparse optionDerrick Stolee via GitGitGadget, Dec 10, 2021
  36. 3/5 t1092: replace 'read-cache --table' with 'ls-files --sparse'Derrick Stolee via GitGitGadget, Dec 10, 2021
  37. 4/5 t1091/t3705: remove 'test-tool read-cache --table'Derrick Stolee via GitGitGadget, Dec 10, 2021
  38. 5/5 test-read-cache: remove --table, --expand optionsDerrick Stolee via GitGitGadget, Dec 10, 2021
  39. Ævar Arnfjörð BjarmasonDec 10, 2021
  40. Elijah NewrenDec 10, 2021
  41. Ævar Arnfjörð BjarmasonDec 11, 2021
  42. Elijah NewrenDec 11, 2021
  43. Elijah NewrenDec 10, 2021
  44. 0/5 Sparse index: fetch, pull, ls-filesDerrick Stolee via GitGitGadget, Dec 22, 2021
  45. 1/5 fetch/pull: use the sparse indexDerrick Stolee via GitGitGadget, Dec 22, 2021
  46. 2/5 ls-files: add --sparse optionDerrick Stolee via GitGitGadget, Dec 22, 2021
  47. 3/5 t1092: replace 'read-cache --table' with 'ls-files --sparse'Derrick Stolee via GitGitGadget, Dec 22, 2021
  48. 4/5 t1091/t3705: remove 'test-tool read-cache --table'Derrick Stolee via GitGitGadget, Dec 22, 2021
  49. 5/5 test-read-cache: remove --table, --expand optionsDerrick Stolee via GitGitGadget, Dec 22, 2021
  50. Elijah NewrenDec 22, 2021
  51. Junio C HamanoDec 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.