Re: [PATCH 2/2] ls-files: add --sparse option

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 8, 2021, 19:06 UTC
Message-ID: <c8e22885-1759-d3d9-3944-2d70c70960e2@gmail.com>
In-Reply-To: <CABPp-BEyvkRdxJoJZcNF1VoQBcJajq1CVUrNTfHnHG433Q=cNQ@mail.gmail.com>

On 12/8/2021 1:36 PM, Elijah Newren wrote:

Show 12 quoted lines

> On Wed, Dec 8, 2021 at 10:23 AM Derrick Stolee <stolee@gmail.com> wrote:
>>
>> On 12/8/2021 12:04 PM, Elijah Newren wrote:
>>>
>>> This actually looks quite nice, though the magic '16' is kind of
>>> annoying.  Could we get rid of that -- perhaps using something to rip
>>> out the diff header, or using comm instead?
>>
>> What I really want is "remove the first two lines of this file"
> 
> Is `tail -n +3` portable?  Looks like we have five uses of tail -n +N
> in the testsuite, so it should be okay to use.

Ah, that's the magic incantation. Sounds good.

>> but perhaps "tail -n $(wc -l expect)" would suffice to avoid a
>> magic number?
> 
> That works too.

If the "-n +X" syntax works, then I'll opt for that.

Thanks!