Re: [PATCH] gc: don't translate literal commands

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 21, 2022, 17:35 UTC
Message-ID: <xmqqa66s4oml.fsf@gitster.g>
In-Reply-To: <YyoPXmNGAvl6p+C2@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

> On Mon, Sep 19, 2022 at 11:07:25PM -0600, Alex Henrie wrote:
>
>> These commands have no placeholders to be translated.
>
> I think this is the right thing to do, but your commit message made me
> pause for a second. When you say "placeholders", I think you mean %s,
> etc. And yes there aren't any here, but that is not the reason not to
> translate. The reason not to translate is that the strings are commands
> which are given to a machine.

I had the same reaction. The strings shown in the choices need to be given as spelled and there is no i18n there.

> So maybe something like:
>
>   There are no human-readable parts of these strings; the command you
>   type is still "git maintenance" even in other languages.

I think calling that "no human-readable" would probably give another confusion, though.

The title uses a good phrase: "literal commands", so the latter half of your rewrite should be sufficient.

    The command you type is still "git maintenance" even in other
    languages.

> Regardless, the patch looks good to me. Thanks for catching it.

Yes.  Good finding.

Will apply.