Re: [PATCH] gc: don't translate literal commands

From: Alex Henrie <alexhenrie24@gmail.com>
Date: Sep 20, 2022, 19:43 UTC
Message-ID: <CAMMLpeRCHbp0OgsXOoMhJcUjS=sUCDJmcA=S1_dbd6Vk31C3+w@mail.gmail.com>
In-Reply-To: <YyoPXmNGAvl6p+C2@coredump.intra.peff.net>

On Tue, Sep 20, 2022 at 1:07 PM Jeff King <peff@peff.net> wrote:

Show 15 quoted lines

>
> On Mon, Sep 19, 2022 at 11:07:25PM -0600, Alex Henrie wrote:
>
> > These commands have no placeholders to be translated.
>
> I think this is the right thing to do, but your commit message made me
> pause for a second. When you say "placeholders", I think you mean %s,
> etc. And yes there aren't any here, but that is not the reason not to
> translate. The reason not to translate is that the strings are commands
> which are given to a machine.
>
> So maybe something like:
>
>   There are no human-readable parts of these strings; the command you
>   type is still "git maintenance" even in other languages.

By "placeholders" I mean "things in angle brackets", like some of the other usage strings in this file have. Maybe "argument placeholders" would be more clear. I like that term a little better than the term "human-readable parts" because these strings are part of the user interface, so humans have to read them. But I really don't care whether there's any explanation in the commit message at all. Junio could just drop the sentence altogether when he commits the patch.

> Regardless, the patch looks good to me. Thanks for catching it.

No problem, and thanks for the feedback.

-Alex