Re: [PATCH] gc: don't translate literal commands

From: Jeff King <peff@peff.net>
Date: Sep 20, 2022, 19:07 UTC
Message-ID: <YyoPXmNGAvl6p+C2@coredump.intra.peff.net>
In-Reply-To: <20220920050725.326383-1-alexhenrie24@gmail.com>

On Mon, Sep 19, 2022 at 11:07:25PM -0600, Alex Henrie wrote:

> These commands have no placeholders to be translated.

I think this is the right thing to do, but your commit message made me pause for a second. When you say "placeholders", I think you mean %s, etc. And yes there aren't any here, but that is not the reason not to translate. The reason not to translate is that the strings are commands which are given to a machine.

So maybe something like:

  There are no human-readable parts of these strings; the command you
  type is still "git maintenance" even in other languages.

Regardless, the patch looks good to me. Thanks for catching it.

-Peff