git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] backfill: handle unexpected arguments

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 22, 2026, 18:06 UTC
Message-ID
<xmqqa4vz91sk.fsf@gitster.g>
In-Reply-To
<45a949f3-8b90-4046-995f-da1df265abfe@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 11 quoted lines
>> +test_expect_success 'backfill rejects unexpected arguments' '
>> +	test_must_fail git -C backfill1 backfill unexpected-arg >err 2>&1 &&
>> +	grep "unknown argument .*unexpected-arg" err &&
>> +	! grep "Minimum number of objects" err
>
> Using test_grep would make test failures easier to debug as it prints a 
> diagnostic message if it fails. Note that "! grep" should become 
> "test_grep !" to ensure the diagnostic message is printed when the 
> expression matches.
>
> Thanks
Great suggestion.  Thanks.
Previous: Phillip WoodNext: Derrick Stolee
Message 8 of 12 in “backfill: handle unexpected arguments”
  1. backfill: handle unexpected argumentsSiddharth Shrimali, Mar 21, 2026
  2. Junio C HamanoMar 21, 2026
  3. Junio C HamanoMar 21, 2026
  4. backfill: handle unexpected argumentsSiddharth Shrimali, Mar 21, 2026
  5. Junio C HamanoMar 22, 2026
  6. backfill: handle unexpected argumentsSiddharth Shrimali, Mar 22, 2026
  7. Phillip WoodMar 22, 2026
  8. Junio C HamanoMar 22, 2026
  9. Derrick StoleeMar 22, 2026
  10. Junio C HamanoMar 23, 2026
  11. Derrick StoleeMar 23, 2026
  12. Siddharth ShrimaliMar 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.