Re: [PATCH v3] backfill: handle unexpected arguments

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2026, 01:01 UTC
Message-ID: <xmqqa4vz7400.fsf@gitster.g>
In-Reply-To: <d8e6f854-e838-439f-bc5a-27cbb4091e4f@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 8 quoted lines

>> +	if (argc) {
>> +		error(_("unknown argument '%s'"), argv[0]);
>> +		usage(builtin_backfill_usage[0]);
>> +	}
>
> Before we get too far into this: How does this interact with
> the ongoing change to introduce revision arguments to 'git
> backfill' [1]?

Ahh, that one completely slipped my mind.

Thanks for a doze of sanity. This patch becomes completely irrelevant if we are taking command line arguments.

It will become the responsibility of the other topic to detect and complain about excess command line parameters (unless the feature it adds absorbs all of them, which may be the case).

> [1] https://lore.kernel.org/git/pull.2070.git.1773707361.gitgitgadget@gmail.com/