From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 22 Mar 2026 18:06:35 GMT
Subject: Re: [PATCH v3] backfill: handle unexpected arguments
Message-ID: <xmqqa4vz91sk.fsf@gitster.g>
In-Reply-To: <45a949f3-8b90-4046-995f-da1df265abfe@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

>> +test_expect_success 'backfill rejects unexpected arguments' '
>> +	test_must_fail git -C backfill1 backfill unexpected-arg >err 2>&1 &&
>> +	grep "unknown argument .*unexpected-arg" err &&
>> +	! grep "Minimum number of objects" err
>
> Using test_grep would make test failures easier to debug as it prints a 
> diagnostic message if it fails. Note that "! grep" should become 
> "test_grep !" to ensure the diagnostic message is printed when the 
> expression matches.
>
> Thanks

Great suggestion.  Thanks.