Re: [PATCH 0/4] remote-hg: more improvements

From: Junio C Hamano <gitster@pobox.com>
Date: May 7, 2014, 18:12 UTC
Message-ID: <xmqq8uqdbgqg.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1399169814-20201-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Here's a bunch of tests more, and a fixes for Mercurial v3.0.

I think the discussion with John Keeping hints that we shouldn't be rushing fc/remote-helpers-hg-bzr-graduation and this does not appear to assume the presense of that series, which is good in order to make these fixes jump over them.

I'll queue this separately on a topic based on the tip of yesterday's master for now.

One thing I couldn't read from the proposed log messages was if this is meant to work with and tested with both v3.0 and pre-v3.0 Hg, or this is to request others who run pre-v3.0 Hg to test these changes.

For example, I see

	from mercurial import changegroup
        if check_version(3, 0):
        	cg = changegroup.getbundle(...)
	else:
        	cg = repo.getbundle(...)

and offhand it was unclear if the unconditional import was a mistake.

Thanks.

Show 11 quoted lines

>
>
> Felipe Contreras (4):
>   remote-hg: add more tests
>   t: remote-hg: add file operation tests
>   t: remote-hg: trivial cleanups and fixes
>   remote-hg: add support for hg v3.0
>
>  contrib/remote-helpers/git-remote-hg |   6 +-
>  contrib/remote-helpers/test-hg.sh    | 240 ++++++++++++++++++++++++++++++++++-
>  2 files changed, 238 insertions(+), 8 deletions(-)