Re: [PATCH 0/4] remote-hg: more improvements

From: David Kastrup <dak@gnu.org>
Date: May 14, 2014, 09:55 UTC
Message-ID: <87iop8u1km.fsf@fencepost.gnu.org>
In-Reply-To: <CAGK7Mr5ezbTVyq2wr7kYWjab6V1srrYwkqSGjo1GuPnkSuGWTQ@mail.gmail.com>

Philippe Vaucher <philippe.vaucher@gmail.com> writes:

Show 13 quoted lines

>>> Thanks for the explanation. I think it underlines well the A)
>>> technical issues (quality commits) and the B) social issues (ability
>>> to communicate in a friendly way & respond constructively), which we
>>> discovered are both *essential* for contributing to git.
>>
>> I'm not entirely convinced of that: there is something akin to drop-dead
>> gorgeous code: code that is so well done that it would not matter with
>> regard to its maintenance whether or not its author dropped dead because
>> it's both done well as well as documented in a manner where the original
>> author could not offer significant additional help.
>
> I think this only means that you can get away with B issues if A's
> quality is very very very high, which doens't happen very often.

I would not exactly say "get away with B issues". It's like saying you can get away with looking like a sleazebag if you plan the time for a complete border search whenever traveling abroad.

Of course that means that traveling into countries where "complete border search" might entail depriving you of your civic rights and locking you up for decades in a torture camp without due process is plainly not an option.

But if you are honest: everybody has to be prepared for that. It's just less likely to occur in practice.

Basically you have to write in a manner "if a seedy stranger gave me that code on a street corner, I would have no problem checking it in". In practice, the shortcuts offering themselves through civil behavior and mutual trust get a lot more work done.

But they _are_ a vector for "social engineering".

You have to admit that it seems pretty unlikely by now that Felipe is trying to sneak in some NSA-written code without arousing people's suspicions.

-- 
David Kastrup