Re: [PATCH v3 2/2] travis-ci: build documentation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 3, 2016, 15:43 UTC
- Message-ID
- <xmqq8tzrp2pd.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <6483CF6A-5C14-42C9-BE1A-6D6AA33999BB@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 22 quoted lines
> On 02 May 2016, at 22:45, Junio C Hamano <gitster@pobox.com> wrote: > >> larsxschneider@gmail.com writes: >> >>> +set -e >>> + >>> +LINKS=$(grep --recursive --only-matching --no-filename --perl-regexp \ >>> + '(?<=linkgit:).*?(?=\[\d+\])' Documentation/* \ >>> + | sort -u \ >>> +) >>> + >>> +for LINK in $LINKS; do >>> + echo "Checking linkgit:$LINK..." >>> + test -s Documentation/$LINK.txt >>> +done >> >> Please separate the above link check out of this step and do so >> separately after the move of test body to a separate script >> settles. > > OK. I also wonder if the link check should rather go to the > "check-docs" Makefile target?
That sounds like a good direction.
Which in turn means that people on all platforms are welcome to run it, which in turn means that the script must be even more portable, with avoiding GNUism and bash-isms etc.