Re: [PATCH v3 2/2] travis-ci: build documentation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 2, 2016, 20:45 UTC
- Message-ID
- <xmqq60uwrxyi.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1462220405-12408-3-git-send-email-larsxschneider@gmail.com>
larsxschneider@gmail.com writes:
Show 11 quoted lines
> +set -e > + > +LINKS=$(grep --recursive --only-matching --no-filename --perl-regexp \ > + '(?<=linkgit:).*?(?=\[\d+\])' Documentation/* \ > + | sort -u \ > +) > + > +for LINK in $LINKS; do > + echo "Checking linkgit:$LINK..." > + test -s Documentation/$LINK.txt > +done
Please separate the above link check out of this step and do so separately after the move of test body to a separate script settles.
When you reintroduce the tests, please make sure the shell script follow the coding style of other scripts. E.g. I do not think the last one in the $(...) needs a backslash continuation at all. I am assuming that you are doing this only on Linux, in which case use of GNUism with grep may be fine.
Show 7 quoted lines
> +make check-builtins > +make check-docs > +make doc > + > +test -s Documentation/git.html > +test -s Documentation/git.xml > +test -s Documentation/git.1