Re: [PATCH v3 2/2] travis-ci: build documentation
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- May 3, 2016, 08:12 UTC
- Message-ID
- <6483CF6A-5C14-42C9-BE1A-6D6AA33999BB@gmail.com>
- In-Reply-To
- <xmqq60uwrxyi.fsf@gitster.mtv.corp.google.com>
On 02 May 2016, at 22:45, Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> larsxschneider@gmail.com writes: > >> +set -e >> + >> +LINKS=$(grep --recursive --only-matching --no-filename --perl-regexp \ >> + '(?<=linkgit:).*?(?=\[\d+\])' Documentation/* \ >> + | sort -u \ >> +) >> + >> +for LINK in $LINKS; do >> + echo "Checking linkgit:$LINK..." >> + test -s Documentation/$LINK.txt >> +done > > Please separate the above link check out of this step and do so > separately after the move of test body to a separate script > settles.
OK. I also wonder if the link check should rather go to the "check-docs" Makefile target?
Show 5 quoted lines
> When you reintroduce the tests, please make sure the shell script > follow the coding style of other scripts. E.g. I do not think the > last one in the $(...) needs a backslash continuation at all. I am > assuming that you are doing this only on Linux, in which case use of > GNUism with grep may be fine.
OK.
Thanks for the review, Lars
Show 8 quoted lines
> >> +make check-builtins >> +make check-docs >> +make doc >> + >> +test -s Documentation/git.html >> +test -s Documentation/git.xml >> +test -s Documentation/git.1