git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pager: disable color when pager is "more"

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 18, 2016, 17:19 UTC
Message-ID
<xmqq8twylv8y.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160718131653.GC19751@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 29 quoted lines
> On Mon, Jul 18, 2016 at 09:19:07AM +0000, Eric Wong wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>> > On Sun, 17 Jul 2016, norm@dad.org wrote:
>> > > 'git diff' outputs escape characters which clutter my terminal. Yes, I
>> > > can sed them out, but then why are they there?
>> > 
>> > Those are most likely the ANSI sequences to add color. Can you call Git
>> > with the --no-color option and see whether the escape characters go away?
>> 
>> Norm: do you have PAGER=more set by any chance?
>> Perhaps changing it to "less" will allow you to preserve colors.
>> 
>> I saw a similar or identical problem during my vacation in
>> FreeBSD-land.  Perhaps the out-of-the-box experience can be
>> improved:
>> 
>> -----8<-----
>> Subject: [PATCH] pager: disable color when pager is "more"
>
> This is the tip of a smaller iceberg. See
>
>   http://public-inbox.org/git/52D87A79.6060600%40rawbw.com/t/#u
>
> for more discussion, and some patches that fix more cases (like "LESS"
> without "R", or "more" that _does_ understand "R"). I think it was
> discarded as being a little too intimate with the details of pagers, but
> it does suck that the out-of-the-box experience on FreeBSD is not good.
> Maybe we should revisit it.
Yup, the three-patch series at
    http://public-inbox.org/git/20140117041430.GB19551%40sigill.intra.peff.net/

would be a safe starting point that is low-impact. I think what ended up being discarded was a more elaborate side topic that started from exploring the possibility of checking if LESS has 'R' in it to see if it is possible to help people with LESS that does not allow coloring explicitly exported.

I do not think the approach in the same thread suggested by Kyle
  http://public-inbox.org/git/62DB6DEF-8B39-4481-BA06-245BF45233E5%40gmail.com/
is too bad, either.
Previous: Jeff KingNext: Jeff King
Message 10 of 12 in “Question: Getting 'git diff' to generate /usr/bin/diff output”
  1. norm@dad.orgJul 16, 2016
  2. Perry HutchisonJul 16, 2016
  3. Johannes SchindelinJul 17, 2016
  4. norm@dad.orgJul 19, 2016
  5. René ScharfeJul 17, 2016
  6. norm@dad.orgJul 17, 2016
  7. Johannes SchindelinJul 18, 2016
  8. pager: disable color when pager is "more"Eric Wong, Jul 18, 2016
  9. Jeff KingJul 18, 2016
  10. Junio C HamanoJul 18, 2016
  11. Jeff KingJul 18, 2016
  12. Eric WongJul 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.