Re: [PATCH] pager: disable color when pager is "more"

From: Jeff King <peff@peff.net>
Date: Jul 18, 2016, 18:58 UTC
Message-ID: <20160718185826.GB24726@sigill.intra.peff.net>
In-Reply-To: <xmqq8twylv8y.fsf@gitster.mtv.corp.google.com>

On Mon, Jul 18, 2016 at 10:19:09AM -0700, Junio C Hamano wrote:

Show 19 quoted lines

> > This is the tip of a smaller iceberg. See
> >
> >   http://public-inbox.org/git/52D87A79.6060600%40rawbw.com/t/#u
> >
> > for more discussion, and some patches that fix more cases (like "LESS"
> > without "R", or "more" that _does_ understand "R"). I think it was
> > discarded as being a little too intimate with the details of pagers, but
> > it does suck that the out-of-the-box experience on FreeBSD is not good.
> > Maybe we should revisit it.
> 
> Yup, the three-patch series at
> 
>     http://public-inbox.org/git/20140117041430.GB19551%40sigill.intra.peff.net/
> 
> would be a safe starting point that is low-impact.  I think what
> ended up being discarded was a more elaborate side topic that
> started from exploring the possibility of checking if LESS has 'R'
> in it to see if it is possible to help people with LESS that does
> not allow coloring explicitly exported.

Yeah, I only re-skimmed the thread, but I had the same impression. I am traveling the next few days, so I will probably not get to it soon. If anybody wants to pick up and rebase/polish those patches as necessary, be my guest.

-Peff